[bugfix]: Fix null pointer de-reference when parsing statistics from cAdvisor #83
+38
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enp0s3
force-pushed
the
npd-fix-cadvisor-stat
branch
3 times, most recently
from
29c9986 to
2de2b11
Compare
|
/cc @Barakmor1 |
Barakmor1
reviewed
Dec 3, 2024
Barakmor1
reviewed
Dec 3, 2024
Barakmor1
reviewed
Dec 3, 2024
Barakmor1
reviewed
Dec 3, 2024
Barakmor1
reviewed
Dec 3, 2024
there might be a situation where pod ranking is done on a freshly created pod whose containers stats are not yet ready in cadvisor. Signed-off-by: Igor Bezukh <[email protected]>
enp0s3
force-pushed
the
npd-fix-cadvisor-stat
branch
from
2de2b11 to
8ff1f7c
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
also fixed a bug in swap stats where swap usage stat was assigned with swap available bytes. Signed-off-by: Igor Bezukh <[email protected]>
enp0s3
force-pushed
the
npd-fix-cadvisor-stat
branch
from
8ff1f7c to
39b1889
Compare
enp0s3
commented
Jan 6, 2025
enp0s3
commented
Jan 6, 2025
| @@ -134,7 +135,23 @@ func exceedMemoryLimits(summary summaryFunc) cmpFunc { | |||
| func hasContainerExceedMemoryLimits(pod *v1.Pod, summary stats_collector.PodSummary) bool { | |||
| for _, container := range pod.Spec.Containers { | |||
| if rQuantity, ok := container.Resources.Limits[v1.ResourceMemory]; ok { | |||
| memoryAndSwapSumQuantity := memoryAndSwapUsage(*summary.Containers[container.Name].MemoryWorkingSetBytes, *summary.Containers[container.Name].MemorySwapCurrentBytes) | |||
| containerStats, exists := summary.Containers[container.Name] | |||
There was a problem hiding this comment.
@Barakmor1 I could avoid code duplication here by appending the regular containers and init containers into a single list, but I prefer to do it in a follow-up, especially that we lack tests to protect us from re-factoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Igor Bezukh [email protected]
Scenario 1: it can happen that API reports about a Pod, but the pod and its containers are not yet
fully created on the node cgroupfs, therefore there can be containers that are missing in the stats.
Scenario 2: Stats API has pointers to counters. Not all counters had default allocation of zero integer.